Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Migrate glacier resources to AWS SDK for Go v2 #31829

Merged
merged 12 commits into from
Jun 7, 2023
Merged

Tech debt: Migrate glacier resources to AWS SDK for Go v2 #31829

merged 12 commits into from
Jun 7, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 7, 2023 •
edited
Loading

Description

Ibid.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccGlacierVault' PKG=glacier ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glacier/... -v -count 1 -parallel 3  -run=TestAccGlacierVault -timeout 180m
=== RUN   TestAccGlacierVaultLock_basic
=== PAUSE TestAccGlacierVaultLock_basic
=== RUN   TestAccGlacierVaultLock_completeLock
=== PAUSE TestAccGlacierVaultLock_completeLock
=== RUN   TestAccGlacierVaultLock_ignoreEquivalentPolicy
=== PAUSE TestAccGlacierVaultLock_ignoreEquivalentPolicy
=== RUN   TestAccGlacierVault_basic
=== PAUSE TestAccGlacierVault_basic
=== RUN   TestAccGlacierVault_notification
=== PAUSE TestAccGlacierVault_notification
=== RUN   TestAccGlacierVault_policy
=== PAUSE TestAccGlacierVault_policy
=== RUN   TestAccGlacierVault_tags
=== PAUSE TestAccGlacierVault_tags
=== RUN   TestAccGlacierVault_disappears
=== PAUSE TestAccGlacierVault_disappears
=== RUN   TestAccGlacierVault_ignoreEquivalent
=== PAUSE TestAccGlacierVault_ignoreEquivalent
=== CONT  TestAccGlacierVaultLock_basic
=== CONT  TestAccGlacierVault_policy
=== CONT  TestAccGlacierVault_basic
--- PASS: TestAccGlacierVault_basic (29.40s)
=== CONT  TestAccGlacierVault_notification
--- PASS: TestAccGlacierVaultLock_basic (29.64s)
=== CONT  TestAccGlacierVault_tags
--- PASS: TestAccGlacierVault_policy (67.27s)
=== CONT  TestAccGlacierVault_ignoreEquivalent
--- PASS: TestAccGlacierVault_tags (66.04s)
=== CONT  TestAccGlacierVaultLock_ignoreEquivalentPolicy
--- PASS: TestAccGlacierVault_notification (73.22s)
=== CONT  TestAccGlacierVaultLock_completeLock
--- PASS: TestAccGlacierVault_ignoreEquivalent (40.39s)
=== CONT  TestAccGlacierVault_disappears
--- PASS: TestAccGlacierVault_disappears (19.87s)
--- PASS: TestAccGlacierVaultLock_completeLock (28.94s)
--- PASS: TestAccGlacierVaultLock_ignoreEquivalentPolicy (38.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glacier	139.685s

@ewbankkit
Use AWS SDK for Go v2 for glacier service.
cafff65
@ewbankkit
Run 'make gen'.
dee0864
@ewbankkit
Add 'names.GlacierEndpointID'.
d966d88
@ewbankkit
Run 'go get github.com/aws/aws-sdk-go-v2/service/[email protected] && …
6587f5b 
…go mod tidy'.
@ewbankkit
glacier: Generate AWS SDK for Go v2 tagging code.
1ff316b
@ewbankkit
r/aws_glacier_vault: Start to migrate to AWS SDK for Go v2.
faf332d
@ewbankkit
Merge branch 'main' into td-migrate-glacier-to-aws-sdk-v2
e2a9ffd
@ewbankkit
Generate 'createTags' for '-AWSSDKVersion=2 -ServiceTagsMap -KVTValues'.
f673398
@ewbankkit
r/aws_glacier_vault: Migrate to AWS SDK for Go v2.
2d4625c
@ewbankkit
r/aws_glacier_vault_lock: Migrate to AWS SDK for Go v2.
fd61da2
@ewbankkit
glacier: Fix sweepers.
aa02cb6
@ewbankkit
Merge branch 'main' into td-migrate-glacier-to-aws-sdk-v2
a0a6ee1 
# Conflicts:
#	internal/service/glacier/vault.go
#	internal/service/glacier/vault_lock.go
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/glacier Issues and PRs that pertain to the glacier service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 7, 2023
@ewbankkit ewbankkit merged commit 1de28dd into main Jun 7, 2023
@ewbankkit ewbankkit deleted the td-migrate-glacier-to-aws-sdk-v2 branch June 7, 2023 21:46
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/glacier Issues and PRs that pertain to the glacier service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @justinretzolk